Mobile browser support and resumable downloads#9
Closed
codeSamuraii wants to merge 10 commits intomainfrom
Closed
Conversation
codeSamuraii
force-pushed
the
universal-version-review
branch
from
ed0f200 to
d5180f7
Compare
codeSamuraii
force-pushed
the
universal-version-review
branch
from
ccebd40 to
4f667a7
Compare
codeSamuraii
force-pushed
the
universal-version-review
branch
from
e45befd to
217508b
Compare
codeSamuraii
changed the title
There was a problem hiding this comment.
Pull Request Overview
Copilot reviewed 11 out of 11 changed files in this pull request and generated 2 comments.
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
| function displayShareLink(elements, transferId) { | ||
| const { shareUrl, shareLink, dropArea } = elements; | ||
| shareUrl.value = `https://transit.sh/${transferId}`; | ||
| shareUrl.value = `${window.location.origin}/${transferId}`; |
There was a problem hiding this comment.
The share URL is hardcoded to use window.location.origin but the original code used https://transit.sh/. This change could break the functionality if the application is deployed on a different domain or uses a CDN.
Suggested change
| shareUrl.value = `${window.location.origin}/${transferId}`; | |
| shareUrl.value = `https://transit.sh/${transferId}`; |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.